Problem: max_gas_wanted not working in sdk 0.50 mempool #1484
Conversation
WalkthroughThis update focuses on synchronizing module versions and fine-tuning test cases within the Changes
Sequence Diagram(s)N/A Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
mmsqe
requested review from
calvinaco and
devashishdxt
and removed request for
a team
|
closes: #1390 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (7)
integration_tests/test_basic.py (7)
Line range hint
48-48: Refactor to use byte literal.The call to
encodefor a string that can be directly represented as a byte literal is unnecessary.- data = hashlib.sha256("gov".encode()).digest()[:20] + data = hashlib.sha256(b"gov").digest()[:20]
Line range hint
570-570: Replace Yoda condition for clarity.Using Yoda conditions can reduce readability. It's more natural to place the variable on the left side of the equality comparison.
- assert 0 == contract.caller.query() + assert contract.caller.query() == 0
Line range hint
576-576: Replace Yoda condition for clarity.Using Yoda conditions can reduce readability. It's more natural to place the variable on the left side of the equality comparison.
- assert 5 * (10**18) == contract.caller.query() + assert contract.caller.query() == 5 * (10**18)
Line range hint
625-625: Replace Yoda condition for clarity.Using Yoda conditions can reduce readability. It's more natural to place the variable on the left side of the equality comparison.
- assert 23828976 == receipt.cumulativeGasUsed + assert receipt.cumulativeGasUsed == 23828976
Line range hint
685-685: Replace Yoda condition for clarity.Using Yoda conditions can reduce readability. It's more natural to place the variable on the left side of the equality comparison.
- assert 2000 == contract.caller.balanceOf(recipient) + assert contract.caller.balanceOf(recipient) == 2000
Line range hint
813-813: Replace Yoda condition for clarity.Using Yoda conditions can reduce readability. It's more natural to place the variable on the left side of the equality comparison.
- assert "Hello" == contract.caller.greet() + assert contract.caller.greet() == "Hello"
Line range hint
822-822: Replace Yoda condition for clarity.Using Yoda conditions can reduce readability. It's more natural to place the variable on the left side of the equality comparison.
- assert "world" == greeter_call_result + assert greeter_call_result == "world"
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (4)
- CHANGELOG.md (1 hunks)
- go.mod (1 hunks)
- gomod2nix.toml (4 hunks)
- integration_tests/test_basic.py (2 hunks)
Files skipped from review due to trivial changes (1)
- go.mod
Additional context used
Ruff
integration_tests/test_basic.py
48-48: Unnecessary call to
encodeas UTF-8 (UP012)Rewrite as bytes literal
570-570: Yoda conditions are discouraged, use
contract.caller.query() == 0instead (SIM300)Replace Yoda condition with
contract.caller.query() == 0
576-576: Yoda conditions are discouraged, use
contract.caller.query() == 5 * (10**18)instead (SIM300)Replace Yoda condition with
contract.caller.query() == 5 * (10**18)
625-625: Yoda conditions are discouraged, use
receipt.cumulativeGasUsed == 23828976instead (SIM300)Replace Yoda condition with
receipt.cumulativeGasUsed == 23828976
685-685: Yoda conditions are discouraged, use
contract.caller.balanceOf(recipient) == 2000instead (SIM300)Replace Yoda condition with
contract.caller.balanceOf(recipient) == 2000
813-813: Yoda conditions are discouraged, use
contract.caller.greet() == "Hello"instead (SIM300)Replace Yoda condition with
contract.caller.greet() == "Hello"
822-822: Yoda conditions are discouraged, use
greeter_call_result == "world"instead (SIM300)Replace Yoda condition with
greeter_call_result == "world"
LanguageTool
CHANGELOG.md
[grammar] ~21-~21: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”? (IF_VB_PCT)
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...
[style] ~26-~26: The double modal “wanted returned” is nonstandard (only accepted in certain dialects). Consider “to be returned”. (NEEDS_FIXED)
Context: ...in/cronos/pull/1484) Respect gas wanted returned by ante handler. ### Bug Fixes * (rpc...
[misspelling] ~128-~128: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives. (CONFUSION_OF_OR)
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...
[uncategorized] ~128-~128: This verb may not be in the correct form. Consider using a different form for this context. (AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
Context: ...edundant parse chainID from gensis when start server. - [#1230](https://github.com/cr...
[uncategorized] ~140-~140: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...52) Add planv1.1.0-testnetto update default max_callback_gas param. ### Improvemen...
[style] ~169-~169: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...
[style] ~170-~170: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...
[style] ~171-~171: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...
[uncategorized] ~171-~171: This verb may not be in the correct form. Consider using a different form for this context. (AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
Context: ...l/769) Prevent cancellation function to be called outside the scope of the contrac...
[uncategorized] ~171-~171: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ... outside the scope of the contract that manage it. - [cronos#775](https://github.com/c...
[style] ~172-~172: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...
[style] ~173-~173: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...
[uncategorized] ~173-~173: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...m//pull/781) Add prune command. - [cronos#830](https://github....
[style] ~174-~174: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...
[style] ~177-~177: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...
[style] ~178-~178: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...
[style] ~179-~179: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...
[style] ~180-~180: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...
[style] ~181-~181: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ov1.10.26and ibc-go tov6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...
[style] ~185-~185: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...
[style] ~186-~186: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...
[style] ~187-~187: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...
[style] ~188-~188: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ull/1184) Update ibc-go tov7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...
[style] ~189-~189: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...
[style] ~190-~190: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...
[style] ~191-~191: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...
[grammar] ~210-~210: It seems that “to” is missing before the verb. (MISSING_TO_BETWEEN_BE_AND_VB)
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...
[misspelling] ~214-~214: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’? (CLEAN_UP)
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...
[uncategorized] ~215-~215: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...pto-org-chain/cronos/pull/1083) memiavl support both sdk 46 and 47 root hash rules. - [...
[uncategorized] ~217-~217: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...pto-org-chain/cronos/pull/1100) memiavl support read-only mode, and grab exclusive lock...
[uncategorized] ~258-~258: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...949) Release static-linked binaries for linux platform. - [#934](https://github.com/c...
[uncategorized] ~329-~329: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...m//pull/781) Add prune command. - [#790](https://github.com/cr...
[grammar] ~330-~330: After ‘it’, use the third-person verb form “fixes”. (IT_VBZ)
Context: ...790) Update cosmos-sdk tov0.46.7, it fix a migration issue which affects pending...
[style] ~397-~397: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...
[uncategorized] ~417-~417: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...0, cosmos sdk to v0.45.4 and gravity to latest, remove v0.7.0 related upgradeHandler. ...
[style] ~419-~419: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...
[style] ~420-~420: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...
[style] ~421-~421: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...
[style] ~436-~436: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...
[style] ~437-~437: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...
[style] ~438-~438: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...
[style] ~456-~456: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...
[style] ~457-~457: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...
[style] ~458-~458: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...
[style] ~459-~459: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...
[style] ~465-~465: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...
[style] ~466-~466: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...
[style] ~480-~480: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...
[style] ~481-~481: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...
[style] ~484-~484: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...
[style] ~492-~492: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...
[uncategorized] ~492-~492: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...b.com//pull/328) display detail panic information in query resul...
[style] ~493-~493: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...query result when--traceenabled. - [cronos#441](https://github.com/crypto-org-chai...
[uncategorized] ~498-~498: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ... Upgrade gravity bridge to v0.3.9 which contain a bugfix onbatchTxExecuted.- [crono...
[style] ~500-~500: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....
[style] ~501-~501: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...
[style] ~502-~502: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t, b) fix data racestraceContext. - [cronos#370](https://github.com/crypto-org-chai...
[style] ~503-~503: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...
[uncategorized] ~503-~503: This verb may not be in the correct form. Consider using a different form for this context. (AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
Context: ...bug fixes: a) fix tx inclusion issue by report correct gasWanted of eth tx, b) Add buf...
[style] ~504-~504: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...
[uncategorized] ~512-~512: You might be missing the article “a” here. (AI_EN_LECTOR_MISSING_DETERMINER_A)
Context: ...in/cronos/pull/255) fix empty topics in non-breaking way - [cronos#270](https://git...
[uncategorized] ~560-~560: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...l/187) multiple denoms can be mapped to same contract - [cronos#157](https://github....
[uncategorized] ~569-~569: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ... 2021* ## v0.6.0 This version removes gravity-bridge from cronos, also includes multi...
[uncategorized] ~612-~612: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...th a patched version of ethermint which include a bug fix on the transaction receipts e...
[uncategorized] ~624-~624: This verb may not be in the correct tense. Consider changing the tense to fit the context better. (AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...
[uncategorized] ~624-~624: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ... to its latest version (v0.5.0.x) which bring several breaking changes (see [changelo...
[uncategorized] ~662-~662: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... version is a new scaffolding of cronos project where ethermint is included as a librar...
[uncategorized] ~668-~668: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...arsis/ethermint/issues/342) Don't clear balance when resetting the account. - (ethermin...
Markdownlint
CHANGELOG.md
52-52: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
64-64: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
72-72: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
80-80: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
88-88: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
89-89: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
90-90: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
94-94: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
102-102: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
103-103: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
104-104: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
105-105: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
106-106: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
107-107: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
111-111: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
112-112: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
118-118: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
119-119: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
120-120: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
121-121: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
122-122: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
126-126: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
127-127: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
128-128: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
129-129: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
138-138: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
139-139: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
140-140: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
144-144: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
145-145: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
146-146: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
154-154: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
155-155: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
159-159: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
167-167: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
168-168: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
169-169: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
170-170: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
171-171: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
172-172: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
173-173: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
174-174: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
175-175: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
176-176: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
177-177: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
178-178: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
179-179: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
180-180: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
181-181: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
182-182: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
183-183: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
184-184: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
185-185: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
186-186: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
187-187: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
188-188: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
189-189: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
190-190: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
191-191: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
195-195: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
196-196: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
197-197: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
198-198: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
199-199: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
200-200: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
201-201: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
202-202: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
203-203: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
204-204: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
205-205: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
206-206: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
207-207: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
208-208: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
209-209: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
210-210: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
214-214: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
244-244: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
245-245: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
247-247: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
248-248: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
249-249: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
257-257: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
258-258: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
259-259: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
263-263: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
264-264: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
265-265: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
266-266: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
267-267: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
268-268: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
269-269: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
277-277: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
285-285: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
289-289: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
290-290: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
291-291: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
299-299: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
303-303: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
304-304: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
305-305: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
313-313: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
321-321: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
329-329: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
330-330: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
339-339: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
347-347: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
355-355: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
363-363: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
364-364: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
374-374: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
382-382: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
383-383: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
391-391: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
395-395: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
396-396: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
397-397: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
405-405: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
417-417: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
418-418: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
419-419: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
420-420: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
421-421: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
422-422: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
423-423: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
427-427: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
428-428: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
429-429: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
433-433: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
434-434: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
435-435: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
436-436: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
437-437: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
438-438: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
446-446: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
454-454: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
455-455: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
456-456: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
457-457: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
458-458: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
459-459: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
463-463: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
464-464: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
465-465: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
466-466: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
474-474: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
475-475: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
476-476: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
477-477: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
478-478: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
479-479: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
480-480: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
481-481: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
482-482: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
483-483: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
484-484: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
485-485: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
489-489: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
490-490: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
491-491: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
492-492: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
493-493: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
497-497: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
498-498: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
499-499: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
500-500: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
501-501: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
502-502: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
503-503: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
504-504: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
512-512: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
513-513: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
521-521: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
529-529: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
530-530: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
531-531: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
535-535: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
536-536: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
544-544: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
545-545: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
546-546: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
547-547: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
548-548: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
556-556: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
560-560: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
561-561: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
562-562: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
563-563: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
573-573: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
577-577: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
578-578: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
579-579: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
580-580: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
584-584: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
585-585: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
596-596: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
597-597: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
598-598: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
599-599: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
600-600: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
604-604: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
605-605: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
606-606: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
616-616: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
617-617: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
628-628: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
632-632: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
633-633: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
634-634: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
635-635: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
636-636: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
637-637: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
639-639: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
640-640: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
648-648: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
652-652: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
656-656: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
666-666: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
667-667: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
668-668: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
669-669: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
675-675: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
676-676: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
680-680: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
38-38: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
46-46: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
58-58: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
66-66: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
74-74: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
82-82: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
96-96: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
114-114: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
148-148: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
161-161: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
251-251: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
271-271: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
279-279: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
293-293: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
307-307: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
315-315: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
323-323: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
333-333: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
341-341: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
349-349: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
357-357: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
368-368: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
376-376: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
385-385: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
399-399: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
407-407: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
411-411: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
440-440: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
448-448: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
468-468: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
506-506: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
515-515: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
523-523: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
538-538: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
550-550: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
565-565: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
587-587: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
608-608: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
619-619: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
642-642: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
658-658: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
Additional comments not posted (5)
gomod2nix.toml (4)
23-23: Updated version and hash forcosmossdk.io/client/v2.The version and hash for the
cosmossdk.io/client/v2module have been updated and it has been redirected togithub.com/crypto-org-chain/cosmos-sdk/client/v2. Ensure that this replacement aligns with the project's requirements and does not introduce any compatibility issues.Verification successful
Updated version and hash for
cosmossdk.io/client/v2verified.The new module version
cosmossdk.io/client/v2is correctly referenced in the project files, and the old version has been replaced consistently. No compatibility issues were found in the project’s issue tracker or recent commit logs.
gomod2nix.tomlgo.modgo.sumapp/app.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the compatibility of the new module version with the project. # Test: Search for any compatibility issues reports in the project's issue tracker. gh issue list --search "cosmossdk.io/client/v2 compatibility"Length of output: 63
Script:
#!/bin/bash # Description: Verify the compatibility of the new module version with the project. # Test 1: Check if the new module version is used in the project. rg 'cosmossdk.io/client/v2' . # Test 2: Check for any references to the old module version. rg 'github.com/crypto-org-chain/cosmos-sdk/client/v2' . # Test 3: Search for any recent commits related to the module update. git log --grep='cosmossdk.io/client/v2'Length of output: 881
48-48: Updated version and hash forcosmossdk.io/store.The version and hash for the
cosmossdk.io/storemodule have been updated, and it has been redirected togithub.com/crypto-org-chain/cosmos-sdk/store. This change should be verified to ensure it does not affect the existing functionality adversely.Verification successful
Updated version and hash for
cosmossdk.io/storeverified.The version and hash for the
cosmossdk.io/storemodule have been updated in thegomod2nix.tomlfile. However, there were no specific mentions of breaking changes related to this module in the documentation or issues.
gomod2nix.toml:
- The updated version and hash for
cosmossdk.io/storeare correctly reflected.- Documentation and issues:
- No explicit breaking changes related to
cosmossdk.io/storewere found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any breaking changes introduced by the new version of the module. # Test: Search for any breaking changes mentioned in the project's documentation or issues. gh issue list --search "cosmossdk.io/store breaking changes"Length of output: 62
Script:
#!/bin/bash # Verify the updated version and hash for `cosmossdk.io/store` in the codebase # Search for the updated version and hash in the gomod2nix.toml file rg 'cosmossdk.io/store' gomod2nix.tomlLength of output: 67
Script:
#!/bin/bash # Search for any mentions of breaking changes related to `cosmossdk.io/store` in the repository's documentation and issues # Search in the documentation rg 'breaking changes' docs/ # Search in the issues gh issue list --search 'cosmossdk.io/store breaking changes'Length of output: 5615
61-61: Updated version and hash forcosmossdk.io/x/tx.The version and hash for the
cosmossdk.io/x/txmodule have been updated, and it has been redirected togithub.com/crypto-org-chain/cosmos-sdk/x/tx. It's critical to confirm that this module's new version integrates smoothly with the rest of the system.
173-174: Updated version and hash forgithub.com/cosmos/cosmos-sdk.The version and hash for the
github.com/cosmos/cosmos-sdkmodule have been updated, and it has been redirected togithub.com/crypto-org-chain/cosmos-sdk. This is a significant change and should be thoroughly tested to ensure that it does not disrupt the project's operations.CHANGELOG.md (1)
26-26: Consider rephrasing for clarity.The phrase "gas wanted returned" might be clearer as "gas that is wanted to be returned".
[STYLE]- Respect gas wanted returned by ante handler. + Respect gas that is wanted to be returned by the ante handler.Tools
LanguageTool
[style] ~26-~26: The double modal “wanted returned” is nonstandard (only accepted in certain dialects). Consider “to be returned”. (NEEDS_FIXED)
Context: ...in/cronos/pull/1484) Respect gas wanted returned by ante handler. ### Bug Fixes * (rpc...
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
New Features
Refactor
Tests
next_block_numandnum.@pytest.mark.skipdecorator to re-enable a previously skipped test.